/ simulated_instruments / triangle
Sign in
simulated_instruments / triangle
Keep the model validation out of the deploy workflow
Jeremy Magland <jmagland@flatironinstitute.org> committed commit 72fb4505dbf4 parent 1056e40 Browse files
1 changed file+7−9
.github/workflows/deploy.ymlmodified+7−9View file
@@ -2,12 +2,18 @@ name: Deploy to Pages
22
33 # Builds webapp/ and publishes it as this repository's site.
44 #
5-# Two notes on the vault:
5+# Three notes on the vault:
66 # - there is no cache service, so setup-node runs without `cache: npm`;
77 # - a mochi site is served at /<collection>/<repo>/site/ or at the root of an
88 # origin of its own. The Vite build uses a relative base (`base: './'`), so
99 # it works at either without being told the deploy path, and configure-pages
1010 # is therefore only here for parity with the deploy step.
11+# - the runner is one small machine shared by every repository in the vault,
12+# so this workflow does no more than install, build, and publish. The model
13+# validation is deliberately not here: `npm run selftest` executes the
14+# MATLAB validation script through numbl, which takes minutes on a
15+# development machine and far longer on the runner. Run it locally before
16+# pushing.
1117
1218 on:
1319 push:
@@ -37,14 +43,6 @@ jobs:
3743 working-directory: webapp
3844 run: npm ci
3945
40- # Runs matlab/triangle_validate.m through numbl: the straight-rod
41- # closed forms, the eigensolve identities, reproducibility of the
42- # seeded roll, and the pinned end-to-end diagnostics. Fails the build
43- # on any mismatch.
44- - name: Validate the model
45- working-directory: webapp
46- run: npm run selftest
47-
4846 - name: Build
4947 working-directory: webapp
5048 run: npm run build
↑↓ move↵openescclose